upgrade go version to 1.24 and fix compatibility issues in client.go …#165
Merged
amitsaha merged 2 commits intoamitsaha:masterfrom Aug 6, 2025
Merged
upgrade go version to 1.24 and fix compatibility issues in client.go …#165amitsaha merged 2 commits intoamitsaha:masterfrom
amitsaha merged 2 commits intoamitsaha:masterfrom
Conversation
…and repositories_test.go
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Go version from 1.21 to 1.24 and addresses compatibility issues with third-party libraries that arose from the version bump.
- Updated Go version requirement in go.mod from 1.21 to 1.24
- Fixed type compatibility issues with Bitbucket client API calls
- Updated dependencies to versions compatible with Go 1.24
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updated Go version to 1.24 and bumped dependency versions for compatibility |
| client.go | Fixed SetApiBaseURL call to pass URL object instead of string |
| repositories_test.go | Applied same SetApiBaseURL fix in test setup |
Comments suppressed due to low confidence (5)
go.mod:3
- Go 1.24 does not exist. The latest stable Go version as of my knowledge cutoff (January 2025) is Go 1.23. Please verify the intended Go version and update to an existing version like 1.23.
go 1.24
go.mod:35
- The version v0.40.0 for golang.org/x/crypto appears to be non-existent. As of my knowledge cutoff, versions in the v0.3x range were the latest. Please verify this version exists or use a valid version.
golang.org/x/crypto v0.40.0 // indirect
go.mod:36
- The version v0.42.0 for golang.org/x/net appears to be non-existent. As of my knowledge cutoff, versions were in the v0.2x range. Please verify this version exists or use a valid version.
golang.org/x/net v0.42.0 // indirect
go.mod:37
- The version v0.34.0 for golang.org/x/sys appears to be non-existent. As of my knowledge cutoff, versions were in the v0.2x range. Please verify this version exists or use a valid version.
golang.org/x/sys v0.34.0 // indirect
go.mod:38
- The version v0.33.0 for golang.org/x/term appears to be non-existent. As of my knowledge cutoff, versions were in the v0.2x range. Please verify this version exists or use a valid version.
golang.org/x/term v0.33.0 // indirect
Owner
|
@princekinlee thank you, could you please update the github actions to run on 1.24 as well as well as update the README? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the project from Go 1.19 to Go 1.24, addressing compatibility issues as requested.
Changes Made
Core Updates
go.modto require Go 1.24go mod tidyto update dependencies to compatible versionsclient.goandrepositories_test.goSpecific Fixes
SetApiBaseURLcalls: Changed fromclient.SetApiBaseURL(url.String())toclient.SetApiBaseURL(*url)to match the updated API signaturerepositories_test.goTesting Performed
Build & Compilation
go buildsucceeds without errorsgo test ./...passes all testsFunctional Testing
ignore-forkand other filters working properlygithub.com/username/repohierarchy createdAuthentication Methods
GITHUB_TOKEN=xxxmethod verifiedNotes
OAuth Device Flow Issue
During testing, discovered that the OAuth device flow throws
panic: device flow not supported. This appears to be a configuration issue with the OAuth application where device flow may not be enabled in the GitHub OAuth app settings. This doesn't affect core functionality as token authentication works perfectly.